-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CUDA in CI #4101
Conversation
|
Should I also bump the librealsense version while I am at it? |
Ideally, only for the 20.04 build I would say. 16.04 addresses the lowest possible versions and 20.04 the highest. Thoughts? |
Sounds good, Tracking these versions as you mentioned on #4099, would allow us to identify and bump versions accordingly, maybe in every release, not sure. |
Will bump real sense version in a seperate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but not to merge
This actually paints the CI red, so adding more PR to resolve the issues would be preferred (rather than changes in this one)
Oh, and the docker images should be updated separate to the CI. That actually allows the pipeline to update them. |
Okay, so let me split this into 3 PR's then:
|
Number 2 has a very high chance of being 1st to be accepted |
This should be good to do now. Have rebased with master. |
Updated Dockerfile for CUDA 10.2 support
Updated Eigen version to resolve CUDA conflict
Updated GCC version to resolved build errors in GPU module