Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[io] Throw error if the device bluffs about its capability #4141

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

kunaltyagi
Copy link
Member

Closes #757, but doesn't go deep into the fix (why does the device actually claim to have a color sensor?)

@kunaltyagi kunaltyagi added module: io needs: feedback Specify why not closed/merged yet labels May 24, 2020
@kunaltyagi kunaltyagi added changelog: enhancement Meta-information for changelog generation needs: code review Specify why not closed/merged yet and removed needs: feedback Specify why not closed/merged yet labels Jun 5, 2020
@kunaltyagi kunaltyagi changed the title [io] Throw error if device claims more capability than provided [io] Throw error if the device bluffs about its capability Jun 5, 2020
@kunaltyagi kunaltyagi marked this pull request as ready for review June 5, 2020 21:46
@kunaltyagi kunaltyagi added this to the pcl-1.12.0 milestone Sep 6, 2020
@kunaltyagi kunaltyagi requested review from koide3 and larshg and removed request for SergioRAgostinho November 4, 2020 13:29
@kunaltyagi kunaltyagi merged commit 89bad57 into PointCloudLibrary:master Nov 5, 2020
@kunaltyagi kunaltyagi deleted the throw-no-segfault branch November 5, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Meta-information for changelog generation module: io needs: code review Specify why not closed/merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASUS Xtion Pro support with OpenNI2
3 participants