[registration] Don't move, or copy ICP #4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THis is a work around the bad design choices in ICP. I'd like for someone to overhaul the desin, but with limited time, this is all I can do. Target milestone: 1.12.0 Closes PointCloudLibrary#2965
kunaltyagi
added
changelog: ABI break
SergioRAgostinho
removed
changelog: ABI break
SergioRAgostinho
approved these changes
Jun 5, 2020
|
I wonder if there can be a check for current milestone. The big green button is very tempting |
|
Why aren't ABI break and behavior change labels valid? Do we choose the best fit label per PR instead? |
|
API breaks implies an ABI break. When viewing the ABI changes section in the change log, you're really only interested in seeing items in which only the ABI changed but not the API. My removal of behavior was incorrect. Effectively you can't copy an ICP object anymore. |
SergioRAgostinho
requested changes
Jun 8, 2020
There was a problem hiding this comment.
Before we merge this: (I'm requesting changes but not really. Just want to keep flag this as don't merge yet)
Is it reasonable to delete the move operations? There should be nothing wrong with moving an ICP object around. And I suspect that by erasing the move you might creating problems for factory like functions. I'll try to compose an example case to illustrate.
The convergence criteria can't be moved that easily since it contains references as well as hidden state that's not exposed by the API. |
kunaltyagi
added
changelog: behavior change
kunaltyagi
added
needs: code review
SergioRAgostinho
approved these changes
Jun 9, 2020
|
Note: Please squash. Not to be merged before 1.12 release is decided |
nlimpert
added a commit
to carologistics/fawkes-robotino
that referenced
this pull request
Apr 8, 2022
Since PCL 1.12 the assignment operator of IterativeClosestPoint has been set to delete which causes an implicit deletion of the inheriting class CustomICP. Refer to PointCloudLibrary/pcl#4167 for further details.
nlimpert
added a commit
to carologistics/fawkes-robotino
that referenced
this pull request
Apr 8, 2022
Since PCL 1.12 the assignment operator of IterativeClosestPoint has been set to delete which causes an implicit deletion of the inheriting class CustomICP. Refer to PointCloudLibrary/pcl#4167 for further details.
nlimpert
added a commit
to carologistics/fawkes-robotino
that referenced
this pull request
Apr 8, 2022
Since PCL 1.12 the assignment operator of IterativeClosestPoint has been set to delete which causes an implicit deletion of the inheriting class CustomICP. Refer to PointCloudLibrary/pcl#4167 for further details.
nlimpert
added a commit
to carologistics/fawkes-robotino
that referenced
this pull request
Apr 8, 2022
Since PCL 1.12 the assignment operator of IterativeClosestPoint has been set to delete which causes an implicit deletion of the inheriting class CustomICP. Refer to PointCloudLibrary/pcl#4167 for further details.
nlimpert
added a commit
to carologistics/fawkes-robotino
that referenced
this pull request
May 21, 2022
Since PCL 1.12 the assignment operator of IterativeClosestPoint has been set to delete which causes an implicit deletion of the inheriting class CustomICP. Refer to PointCloudLibrary/pcl#4167 for further details.
nlimpert
added a commit
to carologistics/fawkes-robotino
that referenced
this pull request
Jul 2, 2022
Since PCL 1.12 the assignment operator of IterativeClosestPoint has been set to delete which causes an implicit deletion of the inheriting class CustomICP. Refer to PointCloudLibrary/pcl#4167 for further details.
nlimpert
added a commit
to carologistics/fawkes-robotino
that referenced
this pull request
Jul 2, 2022
Since PCL 1.12 the assignment operator of IterativeClosestPoint has been set to delete which causes an implicit deletion of the inheriting class CustomICP. Refer to PointCloudLibrary/pcl#4167 for further details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work around the bad design choices in ICP. I'd like for someone to overhaul the design, but with limited time, this is all I can do. Target milestone: 1.12.0
Closes #2965