-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] Export and template extract clusters #4196
[GPU] Export and template extract clusters #4196
Conversation
|
I'd recommend EDIT: Oh, and vector/array map gives the data, which might not have x, y, and z in order for custom types. Since PCL supports custom types (in a convoluted manner), it'd be better to use copyPoint |
gpu/segmentation/include/pcl/gpu/segmentation/impl/gpu_extract_labeled_clusters.hpp
Show resolved
Hide resolved
d500717
to
1cad2ba
Compare
gpu/segmentation/include/pcl/gpu/segmentation/impl/gpu_extract_clusters.hpp
Show resolved
Hide resolved
Hmm, getting other result now than yesterday, so I have to dig a little to why this changed. |
Found the mistake when changing to copypoint 😄 |
gpu/segmentation/include/pcl/gpu/segmentation/gpu_extract_clusters.h
Outdated
Show resolved
Hide resolved
gpu/segmentation/include/pcl/gpu/segmentation/impl/gpu_extract_clusters.hpp
Outdated
Show resolved
Hide resolved
gpu/segmentation/include/pcl/gpu/segmentation/impl/gpu_extract_clusters.hpp
Outdated
Show resolved
Hide resolved
gpu/segmentation/include/pcl/gpu/segmentation/impl/gpu_extract_clusters.hpp
Outdated
Show resolved
Hide resolved
9f0c50f
to
2083ac9
Compare
Marking this as stale due to 30 days of inactivity. Commenting or adding a new commit to the pull request will revert this. |
2083ac9
to
578d5fc
Compare
578d5fc
to
e55f740
Compare
Marking this as stale due to 30 days of inactivity. Commenting or adding a new commit to the pull request will revert this. |
e55f740
to
8119908
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
gpu/segmentation/include/pcl/gpu/segmentation/gpu_extract_clusters.h
Outdated
Show resolved
Hide resolved
Make gpu_extract_clusters exported.
8119908
to
c9f5083
Compare
* Make gpu_extract_clusters templated.
Make gpu_extract_clusters templated.
Make gpu_extract_clusters exported.
Are there a better way than:
When using various point types, to get the XYZ part?