Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Simulation] Don't prefix in shaders. #4209

Merged
merged 1 commit into from
Jul 2, 2020
Merged

[Simulation] Don't prefix in shaders. #4209

merged 1 commit into from
Jul 2, 2020

Conversation

larshg
Copy link
Contributor

@larshg larshg commented Jun 23, 2020

No description provided.

@larshg larshg changed the title Don't prefix in shaders. [Simulation] Don't prefix in shaders. Jun 23, 2020
@larshg larshg mentioned this pull request Jun 23, 2020
Closed
@kunaltyagi
Copy link
Member

Any way to test this at compile time on the CI?

@kunaltyagi kunaltyagi linked an issue Jun 23, 2020 that may be closed by this pull request
vtk & Segmentation faults #1561
Closed
@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation module: simulation labels Jun 23, 2020
@kunaltyagi kunaltyagi added this to the pcl-1.11.1 milestone Jun 23, 2020
@kunaltyagi kunaltyagi added the needs: author reply Specify why not closed/merged yet label Jun 23, 2020
@kunaltyagi
Copy link
Member

Any way to test this at compile time on the CI?

@larshg

@larshg
Copy link
Contributor Author

larshg commented Jul 2, 2020

Ohh, sorry. No, its compiled by OpenGL when loaded.

@kunaltyagi kunaltyagi merged commit a4ab750 into PointCloudLibrary:master Jul 2, 2020
@larshg larshg deleted the FixSimulationTool branch July 4, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunaltyagi kunaltyagi kunaltyagi approved these changes

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: simulation needs: author reply Specify why not closed/merged yet
Projects
None yet
Milestone
pcl-1.11.1
Development

Successfully merging this pull request may close these issues.

vtk & Segmentation faults
3 participants
@larshg @kunaltyagi @SergioRAgostinho