-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pcl_simulation in osx #4325
Enable pcl_simulation in osx #4325
Conversation
simulation/CMakeLists.txt
Outdated
find_package(GLEW) | ||
if(APPLE) | ||
# glew in homebrew installs glew-config.cmake | ||
find_package(glew) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find_package(glew) | |
find_package(glew CONFIG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively just use the the original? The FindGLEW.cmake, finds glew with config search internally.
simulation/CMakeLists.txt
Outdated
@@ -4,7 +4,7 @@ set(SUBSYS_DEPS common io surface kdtree features search octree visualization fi | |||
|
|||
set(build FALSE) | |||
find_package(OpenGL) | |||
find_package(GLEW) | |||
find_package(GLEW CONFIG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't GLEW be found, if you just use the original find_pacakge(GLEW)
?
Else you need to keep the:
if(APPLE)
find_pacakge(glew CONFIG)
ELSE()
find_pacakge(GLEW)
ENDIF()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can, but it's incorrect. The package comes with links to non-existing locations in my setup.
With the old dependencies we managed to build all this
leaving it here to see what happens if we remove pkg-config |
the macos jobs now take more than the gcc stages to build. |
Please go ahead with the merge. Also, please merge the release commit and start the release pipeline. |
2e838cc
to
9693c26
Compare
I've just cleaned up the commits and rebased. I will wait for build completion before merging just to be sure. |
This PR enables building pcl_simulation + associated tools and Qt+VTK things on our CI.
-Werror was disabled to due OpenGl deprecation warnings.