Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common] Allow conversion of PointCloud with more than 32-bit size rows/columns #4343

Merged
merged 3 commits into from
Aug 22, 2020

Conversation

mudskipper75
Copy link
Contributor

Enable conversion of PCLPointCloud2 to PointCloud for clouds with more than 2^28 points.

Enable conversion of PCLPointCloud2 to PointCloud<PointT> for clouds with more than 2^28 points.
@kunaltyagi kunaltyagi added changelog: enhancement Meta-information for changelog generation module: common needs: feedback Specify why not closed/merged yet labels Aug 21, 2020
@kunaltyagi kunaltyagi changed the title Update conversions.h [common] Allow conversion of PointCloud with more than 32-bit size rows/columns Aug 21, 2020
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this, good to go

common/include/pcl/conversions.h Outdated Show resolved Hide resolved
@kunaltyagi kunaltyagi added needs: more work Specify why not closed/merged yet and removed needs: feedback Specify why not closed/merged yet labels Aug 21, 2020
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash merge here.

Waiting on CI 🟢

@kunaltyagi kunaltyagi removed the needs: more work Specify why not closed/merged yet label Aug 21, 2020
@kunaltyagi kunaltyagi merged commit 146ad42 into PointCloudLibrary:master Aug 22, 2020
kunaltyagi added a commit to kunaltyagi/pcl that referenced this pull request Sep 12, 2020
…point_field_types

* origin/new_point_field_types: (211 commits)
  [CI] Make windows build on c:\ drive to fix out-of-disk-space errors (PointCloudLibrary#4382)
  Replace '.points.' with just '.' (PointCloudLibrary#4217)
  [Surface/Poisson4] Always update counter and prevent overflow access in poisson4 octree (PointCloudLibrary#4316)
  [surface/3rdParty] Add stdlib header for malloc in poisson (bugfix for gcc-5) (PointCloudLibrary#4376)
  [Misc] Deprecate unused ease-of-internal-use headers (PointCloudLibrary#4367)
  Use nth_element in median filter nth_element is faster than partial_sort, and should be used for median finding
  enable CUDA on 16.04 CI
  Optimize includes As recommended by include-what-you-use
  Update gpu_install.rst
  Fix getColor()
  Variable needs to be expanded.
  Optimize includes As recommended by include-what-you-use
  [gpu] Add square distances to ApproxNearestSearch (PointCloudLibrary#4340)
  [common] Allow conversion of PointCloud with more than 32-bit size rows/columns (PointCloudLibrary#4343)
  Change the macro to detect and remove deprecations before release
  update docstring
  clang format approx_nsearch.cu
  another indentation fix
  fix indentation and getBitsNum function
  Allow file_io to read large point clouds depending on PCL config (PointCloudLibrary#4331)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Meta-information for changelog generation module: common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants