-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common] Allow conversion of PointCloud with more than 32-bit size rows/columns #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable conversion of PCLPointCloud2 to PointCloud<PointT> for clouds with more than 2^28 points.
kunaltyagi
reviewed
Aug 21, 2020
kunaltyagi
added
changelog: enhancement
Meta-information for changelog generation
module: common
needs: feedback
Specify why not closed/merged yet
labels
Aug 21, 2020
kunaltyagi
changed the title
Update conversions.h
[common] Allow conversion of PointCloud with more than 32-bit size rows/columns
Aug 21, 2020
kunaltyagi
reviewed
Aug 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from this, good to go
kunaltyagi
added
needs: more work
Specify why not closed/merged yet
and removed
needs: feedback
Specify why not closed/merged yet
labels
Aug 21, 2020
kunaltyagi
approved these changes
Aug 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash merge here.
Waiting on CI 🟢
kunaltyagi
added a commit
to kunaltyagi/pcl
that referenced
this pull request
Sep 12, 2020
…point_field_types * origin/new_point_field_types: (211 commits) [CI] Make windows build on c:\ drive to fix out-of-disk-space errors (PointCloudLibrary#4382) Replace '.points.' with just '.' (PointCloudLibrary#4217) [Surface/Poisson4] Always update counter and prevent overflow access in poisson4 octree (PointCloudLibrary#4316) [surface/3rdParty] Add stdlib header for malloc in poisson (bugfix for gcc-5) (PointCloudLibrary#4376) [Misc] Deprecate unused ease-of-internal-use headers (PointCloudLibrary#4367) Use nth_element in median filter nth_element is faster than partial_sort, and should be used for median finding enable CUDA on 16.04 CI Optimize includes As recommended by include-what-you-use Update gpu_install.rst Fix getColor() Variable needs to be expanded. Optimize includes As recommended by include-what-you-use [gpu] Add square distances to ApproxNearestSearch (PointCloudLibrary#4340) [common] Allow conversion of PointCloud with more than 32-bit size rows/columns (PointCloudLibrary#4343) Change the macro to detect and remove deprecations before release update docstring clang format approx_nsearch.cu another indentation fix fix indentation and getBitsNum function Allow file_io to read large point clouds depending on PCL config (PointCloudLibrary#4331) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable conversion of PCLPointCloud2 to PointCloud for clouds with more than 2^28 points.