Deprecate TransformationEstimationDQ in favor of TransformationEstimationDualQuaternion
#4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
added
changelog: deprecation
|
Hm, seems like DQ has never been compiled. For reference: 76f506e is the commit that did the renaming/copying. |
added 2 commits
September 28, 2020 08:52
|
I added that deprecation, too. I was assuming that anything that includes I also undid all the formatting changes. I didn't mean to commit them. |
mvieth
approved these changes
Oct 7, 2020
kunaltyagi
approved these changes
Oct 8, 2020
kunaltyagi
changed the title
TransformationEstimationDQ in favor of TransformationEstimationDualQuaternion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like sometime in 2013,
pcl::registration::TransformationEstimationDQwas being renamed topcl::registration::TransformationEstimationDualQuaternion, but the original name was never removed. This deprecates thetransformation_estimation_dq.hheader, so it can be removed later. I wasn't sure what version to target for removal, so I chose 1.15 based on #4367 .