Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[io] Fix crash in Dinast Grabber due to bad initialization of device handle #4484

Merged

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Nov 3, 2020

Found this during checking the segfault in #4483. Now libusb_claim_interface will not anymore called when no device is found.

Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost Always Zero-init 😆

@kunaltyagi kunaltyagi changed the title Fix crash in libusb_claim_interface due to missing initialization of device_handle_ [io] Fix crash in Dinast Grabber due to bad initialization of device handle Nov 3, 2020
@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation module: io needs: code review Specify why not closed/merged yet labels Nov 3, 2020
@kunaltyagi kunaltyagi merged commit 9e90c89 into PointCloudLibrary:master Nov 5, 2020
@SunBlack SunBlack deleted the libusb_claim_interface_fix branch November 6, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation module: io needs: code review Specify why not closed/merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants