Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix force no recompute #4535

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Fix force no recompute #4535

merged 2 commits into from
Dec 14, 2020

Conversation

JStech
Copy link
Contributor

@JStech JStech commented Dec 4, 2020

Fix to #4455--see discussion there.

@mvieth mvieth added changelog: fix Meta-information for changelog generation module: registration module: test needs: code review Specify why not closed/merged yet labels Dec 5, 2020
mvieth
mvieth approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@mvieth mvieth requested a review from koide3 December 5, 2020 10:26
koide3
koide3 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@koide3 koide3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kunaltyagi kunaltyagi merged commit ba2b709 into PointCloudLibrary:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunaltyagi kunaltyagi kunaltyagi approved these changes

@koide3 koide3 koide3 approved these changes

@mvieth mvieth mvieth approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: registration module: test needs: code review Specify why not closed/merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JStech @kunaltyagi @koide3 @mvieth