Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make euclidean clustering with normals faster #4551

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Make euclidean clustering with normals faster #4551

merged 1 commit into from
Jan 27, 2021

Conversation

mvieth
Copy link
Member

@mvieth mvieth commented Dec 18, 2020 •
edited
Loading

by precomputing angle threshold.
The calls to acos take around 12% of the total time of extractEuclideanClusters.

@mvieth mvieth added needs: code review Specify why not closed/merged yet module: segmentation labels Dec 18, 2020
@mvieth mvieth requested a review from kunaltyagi December 22, 2020 09:37
@mvieth mvieth added the changelog: enhancement Meta-information for changelog generation label Dec 30, 2020
@mvieth mvieth requested a review from koide3 January 26, 2021 16:06
@mvieth mvieth merged commit e2a4c94 into PointCloudLibrary:master Jan 27, 2021
@mvieth mvieth deleted the faster_normals_clustering branch February 8, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshg larshg larshg approved these changes

@koide3 koide3 koide3 approved these changes

@kunaltyagi kunaltyagi Awaiting requested review from kunaltyagi

Assignees
No one assigned
Labels
changelog: enhancement Meta-information for changelog generation module: segmentation needs: code review Specify why not closed/merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvieth @larshg @koide3