-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] Add SSE definitions for SSE 4.1 and 4.2 #4596
Conversation
What about |
Ah, yes. I'll add it. |
e7f6efd
to
bf1c6b1
Compare
@larshg : Can you adjust this MR like the AVX-MR? So |
Sure I'll updated it. |
fb2be7e
to
701a352
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good(-ish) to me (not an expert in either CMake or sse)
check_cxx_source_runs(" | ||
#include <stdlib.h> | ||
int main() | ||
{ | ||
void* mem; | ||
return posix_memalign (&mem, 16, 100); | ||
}" | ||
HAVE_POSIX_MEMALIGN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove this soon. The only place this is used is in linemod (recognition)
@SunBlack Would you have a look 😄 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another review iteration done ;-)
🚀 ? |
Co-authored-by: SunBlack <SunBlack@users.noreply.github.com>
Co-authored-by: SunBlack <SunBlack@users.noreply.github.com>
e99b5dc
to
8b1c729
Compare
* Restructure and add additional SSE definitions Co-authored-by: SunBlack <SunBlack@users.noreply.github.com>
To enable compilation of code that is wrapped in
#if defined __SSE_4_X__