Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Add SSE definitions for SSE 4.1 and 4.2 #4596

Merged
merged 5 commits into from
Apr 15, 2021

Conversation

larshg
Copy link
Contributor

@larshg larshg commented Feb 6, 2021

To enable compilation of code that is wrapped in #if defined __SSE_4_X__

@mvieth
Copy link
Member

mvieth commented Feb 7, 2021

What about SSE3? Not sure if we need that, but for completeness?

@larshg
Copy link
Contributor Author

larshg commented Feb 7, 2021

Ah, yes. I'll add it.

@larshg larshg force-pushed the AddSSEDefinitions branch from e7f6efd to bf1c6b1 Compare February 7, 2021 19:35
@larshg larshg added changelog: enhancement Meta-information for changelog generation module: cmake labels Feb 8, 2021
@SunBlack
Copy link
Contributor

@larshg : Can you adjust this MR like the AVX-MR? So string(APPEND ...) and function instead of macro?

@larshg
Copy link
Contributor Author

larshg commented Feb 16, 2021

Sure I'll updated it.

@larshg larshg force-pushed the AddSSEDefinitions branch 2 times, most recently from fb2be7e to 701a352 Compare March 5, 2021 21:30
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good(-ish) to me (not an expert in either CMake or sse)

Comment on lines +46 to +53
check_cxx_source_runs("
#include <stdlib.h>
int main()
{
void* mem;
return posix_memalign (&mem, 16, 100);
}"
HAVE_POSIX_MEMALIGN)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this soon. The only place this is used is in linemod (recognition)

@larshg
Copy link
Contributor Author

larshg commented Mar 11, 2021

@SunBlack Would you have a look 😄 ?

Copy link
Contributor

@SunBlack SunBlack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another review iteration done ;-)

cmake/pcl_find_sse.cmake Outdated Show resolved Hide resolved
cmake/pcl_find_sse.cmake Outdated Show resolved Hide resolved
cmake/pcl_find_sse.cmake Outdated Show resolved Hide resolved
cmake/pcl_find_sse.cmake Show resolved Hide resolved
cmake/pcl_find_sse.cmake Show resolved Hide resolved
@kunaltyagi
Copy link
Member

🚀 ?

cmake/pcl_find_sse.cmake Outdated Show resolved Hide resolved
larshg and others added 5 commits April 9, 2021 21:21
Co-authored-by: SunBlack <SunBlack@users.noreply.github.com>
Co-authored-by: SunBlack <SunBlack@users.noreply.github.com>
@larshg larshg force-pushed the AddSSEDefinitions branch from e99b5dc to 8b1c729 Compare April 9, 2021 19:23
@larshg larshg merged commit e7939ae into PointCloudLibrary:master Apr 15, 2021
@larshg larshg deleted the AddSSEDefinitions branch April 15, 2021 14:05
mvieth pushed a commit to mvieth/pcl that referenced this pull request Dec 27, 2021
* Restructure and add additional SSE definitions

Co-authored-by: SunBlack <SunBlack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Meta-information for changelog generation module: cmake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants