Add deprecation for incorrectly installed headers #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Problem: some headers are currently installed twice - Add deprecation/redirection headers - Install these headers instead of one set of the "full" headers (so deprecation headers+full headers instead of full headers twice) - If user includes the wrong header (wrong path), it still works, but they get the deprecation notice
mvieth
added
module: recognition
changelog: deprecation
kunaltyagi
approved these changes
Mar 13, 2021
|
@kunaltyagi Oops, sorry, didn't mean to request another review from you |
larshg
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #245 actually added similar deprecation headers before, but they were never installed (so users never got the error/deprecation notice), and later removed.
Fixes issue #3625