Fix problems in octree search functions when using dynamic depth #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
added
changelog: fix
… depth And remove unused variable cloudOut
This fixes segmentation faults for octrees with dynamic depth when a node was cast to a branch node, but was actually a leaf node.
pointSquaredDist returns a float, so it makes no sense to cast it back-and-forth
mvieth
force-pushed
the
octree_dynamic_depth
branch
from
ef54044 to
7abcd66
Compare
larshg
reviewed
Mar 24, 2021
larshg
reviewed
Mar 24, 2021
larshg
approved these changes
Mar 24, 2021
mvieth
changed the title
kunaltyagi
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit messages.
Fixes #1232 Fixes #4591