Add constexpr to static member functions for point types, add macro for if constexpr
#4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
reviewed
Apr 29, 2021
sample_consensus/include/pcl/sample_consensus/impl/sac_model_registration.hpp
Outdated
Show resolved
Hide resolved
kunaltyagi
approved these changes
May 2, 2021
kunaltyagi
changed the title
constexpr to static member functions for point types, add macro for if constexpr
kunaltyagi
added
changelog: enhancement
|
Successfully compiled this PR with C++17 flag, but didn't test if the constexpr functions actually were compile time only |
mvieth
approved these changes
May 2, 2021
larshg
approved these changes
May 2, 2021
#4752 follow up for this MR, covered with static_asserts. didn't cover c++17 macro to be expanded to constexpr if |
mvieth
pushed a commit
to mvieth/pcl
that referenced
this pull request
Dec 27, 2021
… for `if constexpr` (PointCloudLibrary#4735) * static mem functions returning constants made constexpr * static mem functions returning constants made constexpr * static mem functions returning constants made constexpr * static mem functions returning constants made constexpr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a small subset of related [to constexpr point constructors MR] changes