Fix PolygonMesh::concatenate and its unit test
#4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure that each vertex id in a polygon is always in the correct range
kunaltyagi
reviewed
May 8, 2021
use EXPECT_EQ_VECTORS for simplicity
|
@kunaltyagi Thank you for your great suggestion! I've made changes accordingly. |
kunaltyagi
requested changes
May 11, 2021
added 2 commits
May 12, 2021 13:09
- refectored to copy gnd truth for modification - added comments
- moved the temp vector out of the loop - removed redundant comments
kunaltyagi
reviewed
May 12, 2021
kunaltyagi
reviewed
May 12, 2021
- used assignment operator instead - put brackets in one-liner foreach loop
|
The build process failed because of two failing tests which are irrelevant to this issue: What can I do for this? |
|
Tagging @mvieth (Our first seeds for failing tests) |
kunaltyagi
approved these changes
May 13, 2021
kunaltyagi
changed the title
kunaltyagi
changed the title
PolygonMesh::concatenate and its unit test
kunaltyagi
added
changelog: fix
Great, I will investigate those. Although they failed on Windows, and the rand and srand implementations seem to be system dependent, so knowing the seeds might not help me with testing on Ubuntu. But I think I can still find out the causes. |
mvieth
pushed a commit
to mvieth/pcl
that referenced
this pull request
Dec 27, 2021
) * Update PolygonMesh.h * Update test_polygon_mesh.cpp ensure that each vertex id in a polygon is always in the correct range * Update test_polygon_mesh.cpp use EXPECT_EQ_VECTORS for simplicity * Update test_polygon_mesh.cpp fix for the lambda capture issue (https://dev.azure.com/PointCloudLibrary/pcl/_build/results?buildId=18956&view=logs&j=8042da28-3549-5cef-c93d-1a000d12f42a&t=118ad2c4-6739-5a83-709b-f149f9853975&l=192) * Update test_polygon_mesh.cpp - refectored to copy gnd truth for modification - added comments * Update test_polygon_mesh.cpp - moved the temp vector out of the loop - removed redundant comments * Update test_polygon_mesh.cpp - used assignment operator instead - put brackets in one-liner foreach loop Co-authored-by: duhuanxianzi <duhuanncepu@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an addendum to and closes #4572.
Please also refer to the issue #4743.