Update support for CUDA arch in CMake and convertSMVer2Cores
#4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
reviewed
May 7, 2021
kunaltyagi
previously approved these changes
May 13, 2021
|
I approved the PR, but the CI is not happy about the decomposition in the for loop (C++17 feature). Could you please make one final change? :) |
|
Of course, @kunaltyagi! I was already wondering if I am permitted to use c++17. The standard in the Cmakelists is set to 14. Just out of curiosity, could this maybe be updated? The oldest compiler used in the build pipeline seems to be gcc7 which supports all but one PR of c++17. Anyway, thank you again very much for your support! |
kunaltyagi
reviewed
May 14, 2021
kunaltyagi
approved these changes
May 16, 2021
larshg
approved these changes
May 16, 2021
kunaltyagi
changed the title
convertSMVer2Cores
mvieth
pushed a commit
to mvieth/pcl
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kunaltyagi commented in the (unrelated) PR #4719 that a
std::arraycould replace a c-style array. I am just filing this short PR because I think the changed indeed improves the code.