[windows] Fix compile issues when compiling OpenNIDriver

[SunBlack]

Installed OpenNI(1) on my system to get a full build of PCL and got two compile issues:

• error C2039: 'tokenizer': is not a member of 'boost'
• error C2679: binary '[': no operator found which takes a right-hand operand of type 'const openni_wrapper::OpenNIDriver::DeviceContext' (or there is no acceptable conversion)

Last issue was introduced by myself in #2845 3 years ago. As no one mentioned it: Maybe we could also deprecate the OpenNI code (at least of version 1)?

[larshg]

Doesn't seem anyone use it, since its not been reported before now. So I don't mind deprecating the OpenNI(1).
It was not that long ago, one tried to get it working with openNI2, if I remember correctly.

[mvieth]

Thanks!
I am not convinced that deprecating OpenNI(1) is a good idea. Since these problems were windows-only, linux and mac users would have never noticed them

[SunBlack]

@mvieth This issue is not just Windows related ;-)

[mvieth]

@mvieth This issue is not just Windows related ;-)

Really? The two lines with strcpy are wrapped in #ifdef _WIN32, same for all boost:tokenizer instances. I have both OpenNI 1 and 2 installed on my Ubuntu, and openni_driver.cpp always compiled successfully

[SunBlack]

Ops you are right 😆