Small fix in OpenMP for loop #6107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One compiler complained that "‘kdtree’ is predetermined ‘shared’ for ‘shared’". kdtree is a const variable, which are always shared. The solution is to remove kdtree from the shared clause (not explicitly declare it as shared again). Then we also have to remove `default(none)` because otherwise other compilers complain that the data sharing attribute is not explicitly defined for kdtree. Normally, `default(none)` is recommended because it forces the programmer to consider which variables should be shared and which ones private. But since the code is finished, it is okay to remove `default(none)`. Basically, this solution (no `default(none)` and don't explicitly define the const `kdtree` as shared) is the only one that works with all compilers.
mvieth
added
module: registration
changelog: fix
larshg
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One compiler complained that
‘kdtree’ is predetermined ‘shared’ for ‘shared’.kdtreeis a const variable, which are always shared. The solution is to removekdtreefrom the shared clause (not explicitly declare it as shared again). Then we also have to removedefault(none)because otherwise other compilers complain that the data sharing attribute is not explicitly defined for kdtree. Normally,default(none)is recommended because it forces the programmer to consider which variables should be shared and which ones private. But since the code is finished, it is okay to removedefault(none). Basically, this solution (nodefault(none)and don't explicitly define the constkdtreeas shared) is the only one that works with all compilers.Related to #5903
Fixes #6098