-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes and optimizations for sample consensus prerejective (replaces #736) #741
Bug fixes and optimizations for sample consensus prerejective (replaces #736) #741
Conversation
Somehow two extra commits managed to "leak" inside this pull request. You can remove them by doing interactive rebase against upstream master and then force pushing the branch to your fork. |
OK, hope I got it correct this time... |
Hey, here's a quick guide for you on how to edit your commits: You will get the list of your commits
Replace "pick" by "e" if you want to edit a commit, When you are done save the file and you will get a message:
You are now on the oldest commit you selected to edit. Make your changes to the files and do: When you finish the rebasing you will get something like:
Now you can push your new modifications: (note that you must use a fast-forward push, Don't hesitate if you have any question! |
… in all main loop iterations but the first (thanks to Jeppe Pedersen and Kent Hansen for catching this)
…eppe Pedersen and Kent Hansen for the code)
…h faster and more robust pose estimation
Thanks @VictorLamoine, @taketwo . I should have made the changes now |
Looks great now, thanks for the contribution! |
Bug fixes and optimizations for sample consensus prerejective (replaces #736)
This PR solves a few bugs, and makes a number of significant improvements on both speed and robustness of the sample_consensus_prerejective class. It is simply a rehash of #736 with a clean up of the commits.