Updating MoveDetailSerializer to change $effect_chance to actual number

[SKCwillie]

resolve #1024

Take effects text from the seralizer and loop over dictionary looking for "effect_chance" when it is found, replace it with move_effect_chance.

I know the build file was mentioned in the comments of the issue but I don't see a way to edit the build that can be dynamically edited later. It definitely could be possible but will have to be done b someone with more knowledge on the build file than me.

To test this, it can be deployed to Staging and the endpoints can be hit to confirm changes.

[SKCwillie]

Sorry for all the commits. I keep finding issues or small things that can make the code a little cleaner.

[GreatNovaDragon]

i've got a question: is that the text that is displayed via the api, or the internally saved text that is changed here? (I dont know how pokeapi works internally)

I dont think the internal text should be changed, only the displayed text.

[SKCwillie]

@GreatNovaDragon because the proposed change is taking place in the serializers file, the sql.lite database is already built, so no data is getting changed. I'm basically Ctrl F and replacing the $effect_chance in the payload at the last possible moment.

[Naramsim]

@SKCwillie thanks for trying and figuring out how the code works :)

Could you please fix the linting issues? Running black .. Afterwards I can deploy in staging

[SKCwillie]

@Naramsim checks are passing now!

[simonorono]

This is great for the API, however this won't translate to the GraphQL implementation, for that we would need to do this while building the data.

[simonorono]

This code fails for moves without effect entry like dire claw or hard press (both introduced in gen 9).

It could also be written without needing extra or unused variables; here are my suggested changes:

if len(data) > 0:
    for key, value in data[0].items():
        if "$effect_chance%" in value:
            data[0][key] = value.replace(
                "$effect_chance", f"{obj.move_effect_chance}"
            )

[SKCwillie]

I pushed your suggested changes. Definitely a good catch on moves without effect entries

[Naramsim]

In the meantime I deployed the current version to the staging site:

https://staging.pokeapi.co/api/v2/move/fire-punch
https://pokeapi.co/api/v2/move/fire-punch

https://staging.pokeapi.co/api/v2/move/dire-claw
https://pokeapi.co/api/v2/move/dire-claw

But actually what @simonorono says is of great value. I forgot we also have the GQL 😅

[simonorono]

I just realized that it's not possible to do this during the build of the database since several moves share the same effect entry, e.g. fire punch, lava plume, inferno, etc. all share the same effect entry.

[Naramsim]

I just realized that it's not possible to do this during the build of the database since several moves share the same effect entry, e.g. fire punch, lava plume, inferno, etc. all share the same effect entry.

So PokeAPI's Postgres has links for different moves to the same effect entry and it's all dynamic. Correct? Yeah, just checked. So the build step is off-limits.

I see some routes:

• Merging the PR with Simon's fixes and possibly having the GraphQL API only show $effect_chance%.
• Creating and running a tool that beforehand updates the static CSV. This has to be well thought out though.
• Don't do anything. Just manually correct the effect entries and remember that when new data comes in also the effect description of the move has to change.
• studying Postgres/Django/Hasura and checking if they have some ways of referencing data from other tables inside a string text. maybe this or running two queries, one for fetching the text and one for fetching the effect value, then merging the results. Or even using Views

[simonorono]

Another solution could be having the build step generate effect entries for every different value of move_effect_chance

[Naramsim]

Another solution could be having the build step generate effect entries for every different value of move_effect_chance

I don't follow you very well on this but I'm lacking SQL/Django knowledge at the moment.

[pokeapi-machine-user]

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

[pokeapi-machine-user]

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).