Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update encounter_method_prose.csv #1094

Merged
merged 3 commits into from
May 31, 2024
Merged

Update encounter_method_prose.csv #1094

merged 3 commits into from
May 31, 2024

Conversation

DanielSmith13
Copy link
Contributor

Removed duplicate references for Encounter Method 22 French language

Testing: Call https://pokeapi.co/api/v2/encounter-method/22 endpoint, the French translation should now only be included once

Removed duplicate references for Encounter Method 22 French language
@edenbynever
Copy link
Contributor

edenbynever commented May 24, 2024

You're right that the 22,5 tuple is incorrectly repeated twice, but they're not complete duplicates. The fix isn't to remove them, but rather to correct the numbering:

23,9,Headbutting a normal encounter rate tree
- 22,5,En utilisant Coup d’Boule sur un arbre à taux normal
+ 23,5,En utilisant Coup d’Boule sur un arbre à taux normal
24,9,Headbutting a high encounter rate tree
- 22,5,En utilisant Coup d’Boule sur un arbre à taux élevé
+ 24,5,En utilisant Coup d’Boule sur un arbre à taux élevé

@DanielSmith13
Copy link
Contributor Author

Ah yes, you are right, modified this now, also noticed that the data/v2/csv/encounter_condition_value_prose.csv had the values for arceus in party incorrectly linked to condition 10, when I assume they are supposed to reference encounter condition 71

@Naramsim
Copy link
Member

Thanks to both of you! I merge

@Naramsim Naramsim merged commit b5cece1 into PokeAPI:master May 31, 2024
3 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request May 31, 2024
@DanielSmith13 DanielSmith13 deleted the patch-1 branch May 31, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants