Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pokemon.csv to include missing base_experience values #1157

Merged

Conversation

joelesbennett
Copy link
Contributor

Hisuian forms and some other pokemon forms were missing base experience yield values. This change contains addition of the experience yield values - taken from the base forms - for these missed values.

Likely will require a static review, but naturally doesn't change or add testing requirements.

joelesbennett and others added 2 commits October 28, 2024 23:36
Hisuian forms and some other pokemon forms were missing base experience yield values. This change contains addition of these missed values.
@Naramsim
Copy link
Member

Naramsim commented Oct 31, 2024

Hi, I don't have any time to review the changes. Where did you get those values? If it's from a trusted website we can pull them in!

@joelesbennett
Copy link
Contributor Author

Hi! I researched the base forms' base experience values on Bulbapedia, e.g. Hisuian Growlithe's base experience is taken to be the same as Kantonian Growlithe.

@Naramsim Naramsim merged commit f3fd16c into PokeAPI:master Oct 31, 2024
4 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants