Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes some issues #707

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Fixes some issues #707

merged 8 commits into from
Apr 5, 2022

Conversation

Naramsim
Copy link
Member

#703
#700
and another one I cannot find anymore

@Naramsim Naramsim changed the title Fixes some things Fixes some issues Mar 29, 2022
@Naramsim Naramsim requested a review from C-Garza March 30, 2022 07:07
@C-Garza
Copy link
Member

C-Garza commented Apr 2, 2022

Here is the Azure flute issue for reference.

C-Garza
C-Garza reviewed Apr 2, 2022
View reviewed changes
data/v2/csv/pokemon_species.csv Outdated
887,dragapult,8,886,466,5,6,,4,45,50,0,40,0,1,0,0,0,887,
888,zacian,8,,467,2,8,,-1,10,0,0,120,0,1,0,1,0,888,
889,zamazenta,8,,468,8,8,,-1,10,0,0,120,0,1,0,1,0,889,
890,eternatus,8,,469,7,9,,-1,255,0,0,120,0,1,0,1,0,890,
891,kubfu,8,,470,4,,,1,3,50,0,120,0,1,0,1,0,891,
892,urshifu,8,891,470,4,,,1,3,50,0,120,0,1,0,1,0,892,
893,zarude,8,,471,5,,,-1,3,0,0,120,0,1,0,0,1,893,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 891-899 still have their shapes missing.

891: 6,
892: 12,
893: 6,
894: 12,
895: 12,
896: 8,
897: 8,
898: 12

@Naramsim Naramsim requested a review from C-Garza April 4, 2022 18:55
C-Garza
C-Garza approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@C-Garza C-Garza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Naramsim Naramsim merged commit 0dd1c2f into master Apr 5, 2022
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user pokeapi-machine-user mentioned this pull request Apr 5, 2022
Merged
@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Naramsim added a commit to PokeAPI/pokedex that referenced this pull request May 5, 2022
@Naramsim
sync:
3cf3b2b 
PokeAPI/pokeapi#699
PokeAPI/pokeapi#707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C-Garza C-Garza C-Garza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naramsim @C-Garza @pokeapi-machine-user