Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Johto Safari Zone fixes + missing static encounters #750

Merged
merged 5 commits into from
Sep 21, 2022

Conversation

SimplyBLGDev
Copy link
Contributor

After some investigation and talking to the bulbapedia dataminers I now have more accurate information regarding the Johto Safari Zone encounters, so I fixed them up, a lot more simple that I once thought, had to reorganize some IDs too.
As a bonus I fixed a couple erroneous encounters in FR/LG and added some missing static encounters in RSE, more static encounters to be added in the future, watch out for that.

SimplyBLGDev and others added 5 commits August 31, 2022 11:59
Also remove superflous prefixes to Johto Safari Zone location area names
After some more investigating and talking to the bulbapedia maintainers of the Johto Safari Zone page I've been able to gain additional insight on the mechanics and the encounter slots of the safari zone, as such I applied what I learned and had to correct large chunks of data here.
+ Update encounter slots
+ Repositioned encounter slots IDs
+ Updated encounter conditions (Johto Safari Zone's encounter aren't affected by the presence of the national dex)
+ Voltorb and Electrodes at New Mauville
@Naramsim
Copy link
Member

@SimplyBLGDev would you like to become part of pokeapi as a contributor? Nothing fancy but I see you committed many times to the repo.

@SimplyBLGDev
Copy link
Contributor Author

@SimplyBLGDev would you like to become part of pokeapi as a contributor? Nothing fancy but I see you committed many times to the repo.

That'd be fine by me

@Naramsim Naramsim merged commit 710f963 into PokeAPI:master Sep 21, 2022
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants