Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix move types and localize #801

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Fix move types and localize #801

merged 3 commits into from
Jan 4, 2023

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Dec 13, 2022

Sorry, The change I submitted on #783 and #788 is wrong. 🙇

  • English Move names and Chinese names are opposite
  • All new moves' type_id is wrong. I fixed these columns.
  • I modified some generation_id. Moves since Legend Arceus should be 8th generation

I'm so sorry to submit the wrong data.

I checked my local database, it may be correct.

Screenshot 2022-12-14 at 4 16 16

@giginet giginet mentioned this pull request Dec 23, 2022
Open
@Naramsim
Copy link
Member

Ok, don't worry. Do you think I should merge this PR now? Or should other PRs be merged beforehand?

@giginet
Copy link
Contributor Author

giginet commented Dec 27, 2022

@Naramsim This PR is independent of other PRs.
The current master contains wrong data. So could you merge this soon after checking you?

Thorbenl
Thorbenl approved these changes Dec 28, 2022
View reviewed changes
Copy link

@Thorbenl Thorbenl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Naramsim Naramsim merged commit 705d287 into PokeAPI:master Jan 4, 2023
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@Naramsim Naramsim mentioned this pull request Jan 4, 2023
Merged
@giginet giginet deleted the fix-move-types branch January 5, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thorbenl Thorbenl Thorbenl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giginet @Naramsim @pokeapi-machine-user @Thorbenl