Fix Gen/Region/Version data inconsistencies for Gen9

[Pythonic-Rainbow]

Legend Arceus is considered a part of Gen8 on Wikipedia and Bulbapedia. However, it is a special case because it has a different main region from SwSh.

LA is indeed gen8 in version_groups.csv, but some of the data in other csv files are inconsistent. I assume that LA is a part of gen8 in the API. If so, there will be 2 main regions for gen8, but the /generation endpoint specifies main_region as a single Region attribute. What are your plans on this problem?

Another example is that /region/9 (LA:Hisui) currently lists gen9 as its main generation, and /region/10 (SV:Paldea) has no main generation. My commit should swap the results, but Hisui will have no main generation.

[Naramsim]

@tillfox @giginet do you have some thoughts about this issue?

[tillfox]

@tillfox @giginet do you have some thoughts about this issue?

It seems that @Pythonic-Rainbow has fixed problems in "versions.csv", "version_group_regions.csv" and "generations.csv"... which are the other inconsistencies?
Main region for 8th gen is Galar, main region for 9th gen is Paldea, everything is correct. Every Pokemon generation by now has just a main region, it makes sense, unless they create a 10th gen game set in two different regions simultaneously...

[Pythonic-Rainbow]

@tillfox @giginet do you have some thoughts about this issue?

It seems that @Pythonic-Rainbow has fixed problems in "versions.csv", "version_group_regions.csv" and "generations.csv"... which are the other inconsistencies? Main region for 8th gen is Galar, main region for 9th gen is Paldea, everything is correct. Every Pokemon generation by now has just a main region, it makes sense, unless they create a 10th gen game set in two different regions simultaneously...

Yes you're right. Every gen so far has just 1 main region. I thought Hisui is another main region but I did some more research on Bulbapedia and looks like it is just Sinnoh, which is Gen4 main region.

Then yeah, my question is invalid. Sorry for the confusion.

[Pythonic-Rainbow]

I've also added version names, taken from Bulbapedia.

But why are there 3 Japanese locales in https://github.com/PokeAPI/pokeapi/blob/6c3c68a91bb24437f1396c7e3af00d0a9d69a70c/data/v2/csv/languages.csv ? I don't see Roomaji being used anywhere in the csv files, and ID 11 is identical to ID 1 in all the *names.csv that I've found

[giginet]

Looks good.

Hisui will have no main generation.

I don't have any concerns about this.

[giginet]

I don't see Roomaji being used anywhere in the csv files, and ID 11 is identical to ID 1 in all the *names.csv that I've found

I'm a native Japanese. You don't need to set romaji names.

ID 1 and 11 are not identical. ID 1 is ja, and ID 11 is ja without Kanji.
In version names, they seem to be the same. However, flavor texts are different.

[Pythonic-Rainbow]

I don't see Roomaji being used anywhere in the csv files, and ID 11 is identical to ID 1 in all the *names.csv that I've found

I'm a native Japanese. You don't need to set romaji names.

ID 1 and 11 are not identical. ID 1 is ja, and ID 11 is ja without Kanji. In version names, they seem to be the same. However, flavor texts are different.

Ah I see. Thanks for the clarification.

[Naramsim]

Hi @giginet , would you like to become part of @PokeAPI? We really appreciated your help in dumping data

[pokeapi-machine-user]

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

[pokeapi-machine-user]

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

[giginet]

@Naramsim I'm happy to hear about your offer. I can contribute to this repo.
I'm maintaining my product for future series. So I'm going to contribute to this repo to keep a sustainable data source.