Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the CI #49

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix the CI #49

merged 1 commit into from
Dec 13, 2023

Conversation

DahanDv
Copy link
Contributor

@DahanDv DahanDv commented Dec 12, 2023

I'm sorry in advance that this comes without an issue
It seems this has been discussed in some of the latest issues, and there's no point in opening another one

Fixing the CI:

  • adding py versions up to 3.12
  • to keep support for 3.6, a few steps had to be taken:
    • The flake test runs with 3.7 due to Flake's unresolved dependency issue.
    • Flake bumped to the highest version that can run on 3.7 (instead of the latest, which is not compatible with py 3.7)
    • due to a lack of image for py 3.6 with ubuntu-latest, the unit test for py 3.6 runs in a dedicated job on ubuntu 20.04

…age for ubuntu-latest

bump flake version to work around importlib issue python/importlib_metadata#406
@DahanDv DahanDv marked this pull request as ready for review December 12, 2023 18:36
@DahanDv DahanDv changed the title separate job for 3.6 to ubuntu 20 instead of latest due to lacking im… fix the CI Dec 12, 2023
@Naramsim Naramsim merged commit d958bc2 into PokeAPI:master Dec 13, 2023
8 checks passed
@Naramsim
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants