Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon will now be caught from lures #1056

Merged
merged 4 commits into from
Jul 26, 2016
Merged

Pokemon will now be caught from lures #1056

merged 4 commits into from
Jul 26, 2016

Conversation

glennvgastel
Copy link
Contributor

@glennvgastel glennvgastel commented Jul 26, 2016

Short Description:

Pokemon will now be caught from lures

Fixes:

  • When visiting a pokestop, the bot will check for lures and catch any pokemon spawning from it.

Important

PgoAPI should be updated to the latest version!
Instructions will be shown if an outdated version is detected.

2016-07-26 17_31_46-c__windows_system32_cmd exe

self.api.encounter(encounter_id=encounter_id, spawnpoint_id=spawnpoint_id,
player_latitude=player_latitude, player_longitude=player_longitude)

if 'spawn_point_id' not in self.pokemon and 'fort_id' not in self.pokemon:
Copy link
Member

@douglascamata douglascamata Jul 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check for updated pgoapi should be here at all. Please, remove it. Users should setup using the proper setup instruction to get the correct version of it.

@glennvgastel
Copy link
Contributor Author

Removed the warning message and moved the api call to a new method.

@douglascamata douglascamata merged commit 9c99cc0 into PokemonGoF:dev Jul 26, 2016
MFizz pushed a commit to MFizz/PokemonGo-Bot that referenced this pull request Jul 29, 2016
* Pokemon will now be caught from lures

* Pokemon will now be caught from lures - bugfix

* Added a warning message in case the API is outdated

* Remove warning message and move api call to new method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants