-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MoveToMapPokemon to use events instead of logger (similar to #2867) #2881
Conversation
This is better than mine 👍 |
maybe a squash and a rebase is in order, i can't apply this cleanly |
I was just realizing that actually. Hold on. |
# Move To map pokemon | ||
self.event_manager.register_event( | ||
'move_to_map_pokemon_fail', | ||
parameters=('message') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be ('message',)
, otherwise the tuple isn't valid
👍 @TheSavior review this when you can, please. |
Fix emit error. Wrong parameters Remove commented out log.
Can you resolve the conflicts? |
grr. Some help needed: How do I squish or rebase commits that aren't mine so I'm left with just my commits? |
@chrisle easier to clone the project again, copy over your files and open another PR, imho. |
Yeah.. i was starting to think that. OK.. hold on. |
Please disregard this pull request. The merge went south. See PR 2913 instead for cleaner pull request. |
You can rebuild your local branch and force push it to github instead of opening a new pr Also used rebase -i to squash the commits |
Short Description:
Update
MoveToMapPokemon
to use events instead of logger. Same as PR 2867 but includes documentation and a refactor of the module.Fixes: