Make a universal switchyard for GPS assignment. Add config for altitude. #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2016 23:39
…_assignment Conflicts: pokemongo_bot/cell_workers/move_to_map_pokemon.py
|
on pokemongo_bot/cell_workers/follow_spiral.py line 93 |
|
@MZorzy Yep, sorry missed that one. |
|
@BoboFraggins It looks like you have merge conflicts. @douglascamata Can you review this please? |
…_assignment Conflicts: pokecli.py pokemongo_bot/cell_workers/catch_visible_pokemon.py pokemongo_bot/cell_workers/move_to_map_pokemon.py pokemongo_bot/step_walker.py
|
Conflicts resolved. |
|
@BoboFraggins, thanks @douglascamata what are your thoughts here? |
added 2 commits
August 10, 2016 15:03
…_sensor_object_to_handle_all_position_assignment
|
@TheSavior thoughts tomorrow, sorry... too late. |
|
@BoboFraggins I'm thinking about starting a |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Pull all calls to the assignment of the GPS coordinates into a single object. For now this allows for assigning the initial altitude to use instead of always claiming exactly 'sea level'. Longer term this will allow for simulating decaying GPS accuracy (e.g. - +/- 50m when the bot launches and dropping down to +/- 10m as it is running). Those sort of variables would also be configured in the 'gps' section of the config file.
Assumptions:
Closes #2762