Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evolution error for Hitmonlee, Hitmonchan, Dratini #3535

Closed
wants to merge 2 commits into from
Closed

Fix evolution error for Hitmonlee, Hitmonchan, Dratini #3535

wants to merge 2 commits into from

Conversation

jebabin
Copy link
Contributor

@jebabin jebabin commented Aug 10, 2016

Fix evolution error for Hitmonlee, Hitmonchan, Dratini

jebabin referenced this pull request Aug 10, 2016
@jebabin @elicwhite
Fix evolution error in pokemon.json (#3344)
67fe00b 
Fix evolution error in pokemon.json
@amal amal mentioned this pull request Aug 11, 2016
Merged
@amal
Copy link
Contributor

amal commented Aug 11, 2016 •
edited
Loading

Fixed in #3455

julienlavergne
julienlavergne reviewed Aug 11, 2016
View reviewed changes
data/pokemon.json
@@ -5724,6 +5712,12 @@
],
"Weight": "3.3 kg",
"Height": "1.8 m",
"Next evolution(s)": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing second evolution

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jebabin
Copy link
Contributor Author

jebabin commented Aug 11, 2016 •
edited
Loading

@amal sorry I did not see it. But even in #3455 there is still an error for Hitmonlee who is not evolving to Hitmonchan.
@anakin5 fixed

@jebabin jebabin closed this Aug 11, 2016
@jebabin jebabin reopened this Aug 11, 2016
@elicwhite
Copy link
Contributor

Did we lose hitmonchan and hitmonlee in this PR?

@amal
Copy link
Contributor

amal commented Aug 11, 2016

@jebabin yes, thank you! Fixed hitmonchan and hitmonlee info in #3455

@elicwhite
Copy link
Contributor

Seems like this is covered by #3455. Thanks for the PR though @jebabin

@elicwhite elicwhite closed this Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jebabin @amal @elicwhite @julienlavergne