Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.sh to fix for wget: command not found on mac #3592

Closed
wants to merge 1 commit into from
Closed

Update setup.sh to fix for wget: command not found on mac #3592

wants to merge 1 commit into from

Conversation

simonsmh
Copy link
Contributor

A stupid fix for wget: command not found on mac
:(
#3590

A stupid fix for wget: command not found on mac
@mention-bot
Copy link

@simonsmh, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kestel and @nivong to be potential reviewers

@simonsmh simonsmh mentioned this pull request Aug 11, 2016
Closed
@bruvv
Copy link
Contributor

bruvv commented Aug 11, 2016

this is not how you would do this

@jimmywarting
Copy link

Guessing you should do feature detection instead of os detection (like we say on web development)

use wget if it exist
else use curl if it exist

@simonsmh simonsmh closed this Aug 11, 2016
@bruvv
Copy link
Contributor

bruvv commented Aug 11, 2016

this is how you would do it:
#3593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants