Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Be able to evolve pokemon after caught #3725

Closed
wants to merge 1 commit into from
Closed

Fix: Be able to evolve pokemon after caught #3725

wants to merge 1 commit into from

Conversation

joaodragao
Copy link
Contributor

Caught Pokemon won't be found in order to evolve because EvolvePokemon class doesn't get there current list of Pokemon. This bug leads to caught Pokemon being released without evolving.

@mention-bot
Copy link

@joaodragao, thanks for your PR! By analyzing the annotation information on this pull request, we identified @aeckert, @achretien and @douglascamata to be potential reviewers

@achretien
Copy link
Contributor

Agreed with this PR while the inventory class not implemented everywhere

@joaodragao
Copy link
Contributor Author

Btw my account got perm ban and I can't test it anymore :(

@brantje
Copy link
Contributor

brantje commented Aug 12, 2016

@joaodragao If you need an account pm me on slack

@Foulwerp
Copy link

Foulwerp commented Aug 12, 2016

This is working wonderful. Fixes the issues of having to put the EvolvePokemon task above the catch tasks. Now I can catch, evolve, release all in the same tick.

@douglascamata
Copy link
Member

douglascamata commented Aug 12, 2016

@joaodragao this is not a fix, this is a hack. We want every singlet ask to use the cached inventory (updating it properly) and not to request it again.

@joaodragao
Copy link
Contributor Author

@brantje Thanks! I'll be back to you later.

@joaodragao
Copy link
Contributor Author

@douglascamata I think if we don't want to request from api again, we might save caught Pokemons for later combining with all Pokemons a player has. But doing this is async with server.

@douglascamata
Copy link
Member

@joaodragao we need to make CatchPokemon and ReleasePokemon update the inventory cache and it will be good. Nothing needs to be asynchronous.

@joaodragao
Copy link
Contributor Author

Ok! I'll check it.

@achretien
Copy link
Contributor

@joaodragao can you test #3738 ?

@joaodragao joaodragao closed this Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants