-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Be able to evolve pokemon after caught #3725
Conversation
@joaodragao, thanks for your PR! By analyzing the annotation information on this pull request, we identified @aeckert, @achretien and @douglascamata to be potential reviewers |
Agreed with this PR while the inventory class not implemented everywhere |
Btw my account got perm ban and I can't test it anymore :( |
@joaodragao If you need an account pm me on slack |
This is working wonderful. Fixes the issues of having to put the EvolvePokemon task above the catch tasks. Now I can catch, evolve, release all in the same tick. |
@joaodragao this is not a fix, this is a hack. We want every singlet ask to use the cached inventory (updating it properly) and not to request it again. |
@brantje Thanks! I'll be back to you later. |
@douglascamata I think if we don't want to request from api again, we might save caught Pokemons for later combining with all Pokemons a player has. But doing this is async with server. |
@joaodragao we need to make CatchPokemon and ReleasePokemon update the inventory cache and it will be good. Nothing needs to be asynchronous. |
Ok! I'll check it. |
@joaodragao can you test #3738 ? |
Caught Pokemon won't be found in order to evolve because
EvolvePokemon
class doesn't get there current list of Pokemon. This bug leads to caught Pokemon being released without evolving.