Fix update_live_stats not showing correct experience

[vicch]

Short Description:

update_live_stats not showing correct level xp and completion figures by using prev_level_xp which should instead by current level's xp.

Fixes (provide links to github issues if you can):

[mention-bot]

@vicch, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Moonlight-Angel, @sergiopalacio and @TheSavior to be potential reviewers

[johannlejeune]

Yep, that's correct. I noticed it already.
The problem is, the values returned by the server contains the values for the previous level and the next level. I couldn't find any values indicating experience threshold for the current level.
Also, UpdateLiveStats doesn't calculate this value itself. It takes it from the Metrics class. So the wrong XP calculation also appears in the summary when you stop the bot.
Thus the fix should be implemented in the Metrics class.

[vicch]

@Moonlight-Angel Metric has xp_earned() and xp_per_hour(), not actually related to levels. And summary only shows Total XP Earned: 85630 Average: 60801.72/h, so it doesn't seem necessary to modify other logics except UpdateLiveStats.

[elicwhite]

@Moonlight-Angel, I defer to you on this PR

[johannlejeune]

@vicch My bad, it's not shown in the summary when the process exits.
Take a look at the stats shown right after login, the same issue should be present there.
In this case, the same issue is present in the get_player_info method in pokemongobot.__init__.py.
And yes, these values are also computed in update_live_stats.py. Maybe it would be a better idea to create another method somewhere to calculate these values and call them in both __init__.py and update_live_stats.py.

Sorry about the delay and the false path. My accounts got banned with my IP, I can't login anymore to check right now. 😂

[vicch]

@Moonlight-Angel I see. Ideally there should be a helper that retrieves player stat/level stuff. Searching player_stats you can see workers and other classes doing this by themselves. I'm not confident enough to refactor these. I will have a look.

[smfbrooks]

While we're at it, can #2596 be fixed?

[douglascamata]

Is this PR dead or alive?

[vicch]

Waiting improvements, closed for now.

[Gurzeh]

@vicch check #4589 there are some clean still pending (putting list in data rep), but it solves the issue