Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some eggs info in metrics #4410

Merged
merged 2 commits into from
Aug 21, 2016
Merged

Some eggs info in metrics #4410

merged 2 commits into from
Aug 21, 2016

Conversation

ps1dr3x
Copy link
Contributor

@ps1dr3x ps1dr3x commented Aug 20, 2016

next_egg_hatching value is updated when the incubate_eggs worker checks the walked distance
hatched_eggs value is updated by the incubate_eggs worker when a egg hatches

… distance (km) to next egg hatching (next_egg_hatching) in metrics/UpdateLiveStats #4150
@mention-bot
Copy link

@ps1dr3x, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Kassadd, @rawgni and @Moonlight-Angel to be potential reviewers

@solderzzc
Copy link
Contributor

CI failed
`

ERROR: test_get_stats_line (tests.update_live_stats_test.UpdateLiveStatsTestCase)

Traceback (most recent call last):
File "/home/travis/build/PokemonGoF/PokemonGo-Bot/tests/update_live_stats_test.py", line 174, in test_get_stats_line
line = self.worker._get_stats_line(self.player_stats)
File "/home/travis/build/PokemonGoF/PokemonGo-Bot/pokemongo_bot/cell_workers/update_live_stats.py", line 253, in _get_stats_line
'next_egg_hatching': 'Next egg hatches in : {:.2f} km'.format(next_egg_hatching),

ValueError: Unknown format code 'f' for object of type 'str'

`

@solderzzc solderzzc merged commit 4c6c5f2 into PokemonGoF:dev Aug 21, 2016
@ps1dr3x ps1dr3x deleted the dev branch August 21, 2016 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants