Pokemon optimizer improvements #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take into account the candy rewarded at evolution
|
@anakin5, thanks for your PR! By analyzing the annotation information on this pull request, we identified @BriceSD, @RedViper9 and @DeXtroTip to be potential reviewers |
| @@ -29,13 +29,13 @@ def initialize(self): | |||
| self.max_pokemon_storage = inventory.get_pokemon_inventory_size() | |||
| self.last_pokemon_count = 0 | |||
|
|
|||
| self.config_transfer = self.config.get("transfer", False) | |||
| self.config_evolve = self.config.get("evolve", False) | |||
| self.config_transfer = self.config.get("transfer", True) | |||
There was a problem hiding this comment.
I'd prefer things to be off by default.
If we use the default value, they are probably missing important stuff in their config.
|
done |
| self.config_evolve_count_for_lucky_egg = self.config.get("evolve_count_for_lucky_egg", 90) | ||
| self.config_may_use_lucky_egg = self.config.get("may_use_lucky_egg", False) | ||
| self.config_evolve_count_for_lucky_egg = self.config.get("evolve_count_for_lucky_egg", 92) | ||
| self.config_may_use_lucky_egg = self.config.get("may_use_lucky_egg", True) |
There was a problem hiding this comment.
Could we revert this as well?
|
done |
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have 23 candies and 2 Pidgey (at 12 evolution cost), the previous formula give us that only one of them can be evolved:
(23 + 2) / (12 + 1) = 1
The fixed formula return that both can be evolved (which is correct):
(23 + 2 - 1) / 12 = 2