Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not always snipe vip pokemon if using snipe_high_prio_threshold #4530

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

anhvn01457
Copy link
Contributor

Short Description:

  • I think we don't need to always snipe vip pokemon, if that pokemon is needed for sniping, it should have higher priority than threshold. By that we can sure vip pokemon is till catch with Berry & Best Ball but no need to snipe (avoid ban)

@mention-bot
Copy link

@anhvn01457, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Raiven66, @chrisle and @mhdasding to be potential reviewers

@solderzzc
Copy link
Contributor

Snipe and vip should not merged in configuration.
The snipe score is very clear.

@anhvn01457
Copy link
Contributor Author

@solderzzc how about the case when I want Dratini is Vip to secure catch rate but don't want to snipe on Dratini?

@solderzzc
Copy link
Contributor

Hmm, I don't get it. But I realized one reason for this commit, catch with Berry & Best Ball

@anhvn01457
Copy link
Contributor Author

Yes, it is. I want that pokemon is catch with Berry & Best Ball but not snipe on it

@solderzzc
Copy link
Contributor

Oh, I was thinking the config is in the reverted way.

@solderzzc
Copy link
Contributor

Why you just don't enable the Snipe task?

@anhvn01457
Copy link
Contributor Author

I want snipe on other pokemons.
Example:
my vip pokemon is Dratini, Dragonite because I want to catch them with berry & best ball. But I only want snipe on Dragonite

@solderzzc
Copy link
Contributor

I see, that's reasonable.

@solderzzc solderzzc merged commit 5dffe24 into PokemonGoF:dev Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants