Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape slash and double quotes characters for password in setup.sh #4574

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

hlung
Copy link
Contributor

@hlung hlung commented Aug 22, 2016

Passwords may contain special characters that may break bash sed command (slashes) or json format (double quotes). This allow those kinds of password to be used safely.

PS. My bash skill is not strong so any advice is appreciated! :)

@mention-bot
Copy link

@hlung, thanks for your PR! By analyzing the annotation information on this pull request, we identified @simonsmh, @nivong and @rawgni to be potential reviewers

@solderzzc
Copy link
Contributor

Thanks for the PR>

@solderzzc solderzzc merged commit 61753fc into PokemonGoF:dev Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants