Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teleporting when Google API directions quota reached #4575

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Fix teleporting when Google API directions quota reached #4575

merged 1 commit into from
Aug 22, 2016

Conversation

th3w4y
Copy link
Contributor

@th3w4y th3w4y commented Aug 22, 2016

Short Description:

Polyline improvements

Fixes/Resolves

  • Fix teleporting when API quota reached
  • Add unittest tests for the Polyline class (including pickles for directions and elevation responses)
  • Add requests-mock to requirements.txt
  • Remove the old ad-hoc polyline_generator_tester.py

@mention-bot
Copy link

@th3w4y, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kanemasa1987, @sinap and @asnelzin to be potential reviewers

Add requests-mock to requirements
@solderzzc
Copy link
Contributor

Good style, less coding, more testing code :)

@solderzzc solderzzc merged commit 30cdaf6 into PokemonGoF:dev Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants