Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #4621 (broken 'any' after addition of 'all') #4639

Merged
merged 4 commits into from
Aug 24, 2016

Conversation

LitRidl
Copy link
Contributor

@LitRidl LitRidl commented Aug 24, 2016

Fixes #4621:

  • 'any' had default logics (if pokemon name is not found in release config, the value is taken from 'any'). So, if user haven't specified 'all', bot took 'any' and launched it's through the whole pokemon bag, not through the pokemon group.

…N best ones

* "release": {"all": keep_best_cp": 100} globally keeps 100 best CP pokemon
* fixed description of 'any' in docs and configs
* added 'all' example in config files
* added example of 'all' to docs
@mention-bot
Copy link

@LitRidl, thanks for your PR! By analyzing the annotation information on this pull request, we identified @alvarogzp, @Nihisil and @achretien to be potential reviewers

@takenek
Copy link

takenek commented Aug 24, 2016

Cool - so someone tell me what i must config now to got every pokemon with the best IV nothing else and rest go to candys?
Because now i completly don't understand this...
I got now:
"release": {
"// Keep no more than 1 best IV pokemon for every pokemon type": {},
"any": {"keep_best_iv": 1},
},

And i got 20 pidgey....
I use newlatest version of Master branch: de78768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants