Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summary for 1st run of fresh acct #4712

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Fix summary for 1st run of fresh acct #4712

merged 1 commit into from
Aug 25, 2016

Conversation

mjmadsen
Copy link
Contributor

When running a brand spanking new account for the 1st time, we printed an invalid summary report.

  • Switched default values
  • Removed default value check that assigned start to latest

From what I can tell, there was no need to assign everything to -1 if we have a fresh account then assign all start values to latest at the end.

Closes half of #4687

@mention-bot
Copy link

@mjmadsen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @gfreivasc, @bstpierr and @sohje to be potential reviewers

@mjmadsen
Copy link
Contributor Author

2016-08-25 14:40:39,569 [ cli] [INFO]
2016-08-25 14:40:39,569 [ cli] [INFO] Ran for 0:08:00
2016-08-25 14:40:39,569 [ cli] [INFO] Total XP Earned: 3780 Average: 28340.28/h
2016-08-25 14:40:39,569 [ cli] [INFO] Travelled 0.33km
2016-08-25 14:40:39,569 [ cli] [INFO] Visited 12 stops
2016-08-25 14:40:39,569 [ cli] [INFO] Encountered 5 pokemon, 5 caught, 0 released, 0 evolved, 5 never seen before ()
2016-08-25 14:40:39,569 [ cli] [INFO] Threw 4 pokeballs
2016-08-25 14:40:39,570 [ cli] [INFO] Earned 500 Stardust
2016-08-25 14:40:39,570 [ cli] [INFO] Hatched eggs 0
2016-08-25 14:40:39,570 [ cli] [INFO]
2016-08-25 14:40:39,570 [ cli] [INFO] Highest CP Pokemon: Golbat [CP: 134] [IV: 14/6/5] Potential: 0.56
2016-08-25 14:40:39,570 [ cli] [INFO] Most Perfect Pokemon: Staryu [CP: 11] [IV: 9/8/10] Potential: 0.6

Looks like she's working.

@mjmadsen mjmadsen merged commit d7b4780 into PokemonGoF:dev Aug 25, 2016
@k4n30
Copy link
Contributor

k4n30 commented Aug 26, 2016

@mjmadsen looks like a revert of #4127 are you sure you've handled all cases. Only reason I raise this is it went from NONE -> 0 -> -1 -> 0 Just making sure we aren't creating regressions

@mjmadsen
Copy link
Contributor Author

@k4n30 I'll take a closer look when I get home. Tests earlier seemed to be reporting everything correctly for new and old accounts. From the looks of it the issues could have be solved by changing the checks to 0 instead of None - but you'd still have the problem with fresh accounts since we're setting latest to start.

@k4n30
Copy link
Contributor

k4n30 commented Aug 26, 2016

Will leave it to you, just wanted to bring it to your attention

@mjmadsen mjmadsen mentioned this pull request Aug 26, 2016
solderzzc added a commit that referenced this pull request Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants