Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live config update #4738

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Conversation

alexyaoyang
Copy link
Contributor

@alexyaoyang alexyaoyang commented Aug 25, 2016

Live config update

This feature is based on #4359. Thanks @sohje!

Fixes/Resolves/Closes (please use correct syntax):

  • Detect config changes on the fly #3588
  • Allows 2 modes:
  • Normal live update for entire config file
    screenshot 2016-08-25 at 2 47 35 pm
  • Quick update for tasks only (without relogin)
    screenshot 2016-08-25 at 2 46 14 pm
  • Defaults to disable, users have to enable explicitly (and hopefully read the doc to understand the differences between the modes)
  • Cross platform compatible

@mention-bot
Copy link

@alexyaoyang, thanks for your PR! By analyzing the annotation information on this pull request, we identified @TheSavior, @mhdasding and @bruno-kenji to be potential reviewers

@sohje
Copy link
Contributor

sohje commented Aug 25, 2016

@alexyaoyang Seems good ;]
CI is broken?

@solderzzc
Copy link
Contributor

Rerun CI.

@solderzzc
Copy link
Contributor

Wow, really, a live change happen :)

@solderzzc solderzzc merged commit bc69ca1 into PokemonGoF:dev Aug 26, 2016
@alexyaoyang
Copy link
Contributor Author

@sohje Thank you! :) @solderzzc Yes, I found it quite convenient for tweaking config 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants