Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix first egg incubating #4748

Merged
merged 2 commits into from
Aug 26, 2016
Merged

Conversation

DeXtroTip
Copy link
Contributor

@DeXtroTip DeXtroTip commented Aug 26, 2016

Short Description:

Seems like when incubating first egg the start_km_walked is not found and the bot will use 9001. Maybe if we set it to 0 it might work, since after this, every other time the start_km_walked is found.
Fixed it.

Fixes/Resolves/Closes (please use correct syntax):

@mention-bot
Copy link

@DeXtroTip, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rawgni, @reddivision and @douglascamata to be potential reviewers

@k4n30
Copy link
Contributor

k4n30 commented Aug 26, 2016

9001? wtf

@rawgni
Copy link
Contributor

rawgni commented Aug 26, 2016

@mjmadsen

@mjmadsen
Copy link
Contributor

Let me take a look in a bit.

@mjmadsen
Copy link
Contributor

Took me entirely too long looking into the shelve key error. This looks good (on a 2nd run account).

Thanks for the PR!

@mjmadsen mjmadsen merged commit f6aca81 into PokemonGoF:dev Aug 26, 2016
@DeXtroTip DeXtroTip deleted the fix_incubate_eggs branch August 26, 2016 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants