Fix bot crash at start if permabanned #4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @TheSavior and @mjmadsen to be potential reviewers |
Gobberwart
changed the title
|
It looks like there are a number of other events that MIGHT be raised during bot startup that will cause crash if the bot is still set to "False". This PR should fix all of those. |
|
Thanks for the PR |
alexyaoyang
pushed a commit
to alexyaoyang/PokemonGo-Bot
that referenced
this pull request
Aug 28, 2016
alexyaoyang
added a commit
that referenced
this pull request
Aug 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Bot not initialised (still set to "False") before trying to access event manager caused the following error:
Separated bot initialize and start methods.
Fixes/Resolves/Closes (please use correct syntax):