remove equip_badge call, iso version does not add eqiup_badge to play… #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er data when badge is awarded. so this may have been in their api but it was never fully implemented
|
Thanks for the PR and the detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
having testing the iso version on awarded badges and what changes in the player data. it seems equip_badge call is not needed as the player_data does not change. As such deletion of commented out code and message which is not required. The delay is still required as badges do take time to display and accept and if multiple badges are awarded each badge needs to be accepted before the next is displayed. Note you can capture multiple pokemon before the awards show up so it is built into the heartbeat and the heartbeat seems to be delayed till you are back on the map and have not issued another event/action.
Resolves:
resolves #4522