Add PokemonGo bot version to docker image

[walkerlee]

Short Description:

add commit version when create docker image

related to #4884

[mention-bot]

@walkerlee, thanks for your PR! By analyzing the annotation information on this pull request, we identified @th3w4y, @Gobberwart and @alexyaoyang to be potential reviewers

[th3w4y]

@walkerlee something like this should be simpler:

LABEL BUILD_COMMIT $(curl -H "Accept: application/vnd.github.VERSION.sha" https://api.github.com/repos/$BUILD_REPO/commits/$BUILD_BRANCH)

[walkerlee]

@th3w4y yes, but how can we get docker label in docker container?

[th3w4y]

@walkerlee you are right cannot execute on LABEL

[BreezeRo]

Please merge latest dev changes into this branch first

[th3w4y]

@walkerlee I see you rebased 10c713c...c516a95 and now travis is passing?
i had the same commit 10c713c NOT failing on my travis repo.. https://travis-ci.org/th3w4y/PokemonGo-Bot/builds/155958771

very strange...

[walkerlee]

@th3w4y yes, it's passed
I also test it on my local docker image (python -m unittest discover -v -p "*_test.py")
first test was failed but others were succeed

[mjmadsen]

👍

[walkerlee]

and now image size is 85.28 MB 👍

⋊> ~/pgo on add-pokebot-version  docker images                                                                                                                                                                                       
REPOSITORY                TAG                 IMAGE ID            CREATED             SIZE
walkerlee/pokemongo-bot   latest              1ebfb4bcdefe        38 minutes ago      85.28 MB
svlentink/pokemongo-bot   latest              9d4f4c4b52d3        About an hour ago   121.6 MB

[mjmadsen]

The out-of-date seems to apply to files that are not in the PR request, merging them in that case does not cause a conflict. If there are merge conflicts or CI failures are when we need to rebase. I think merge conflicts extend to attempting to merge to files that have been updated since the original PR file's last commit. Like many in the project, I am new to github.

[th3w4y]

i tried to make it even smaller using PyInstaller on alpine (http://www.pyinstaller.org) managed to bring it down to 32MB (pokecli executable was 24MB ())..

but it was not functional... I would still have to try to figure out why it did not load the protobuff correctly

For reference: I tried some variation on the https://github.com/six8/pyinstaller-alpine without the encrypting the binary..

[walkerlee]

@th3w4y maybe use python:2.7-alpine as base image is better
it's only update pokemongo-bot layers
what do you think?

[th3w4y]

@walkerlee I tested that and noticed that python:2.7-alpine is about 20MB bigger then a image with FROM alpine at the step
RUN apk add python py-pip

[walkerlee]

@th3w4y yes, but that base image, only need to pull that layer once

[th3w4y]

then we should split like below:

FROM alpine  #layer 1
RUN apk -U --no-cache add python py-pip #layer 2

ARG BUILD_REPO=PokemonGoF/PokemonGo-Bot
ARG BUILD_BRANCH=master
ARG TIMEZONE=Etc/UTC

LABEL build_repo=$BUILD_REPO build_branch=$BUILD_BRANCH #layer 3

....

then Dockerfile continues...

[walkerlee]

@th3w4y you're right

[th3w4y]

@walkerlee i'm surprise we did not see it before 🎯

[walkerlee]

@th3w4y have you tried this Dockerfile command?
ADD http://pgoapi.com/pgoencrypt.tar.gz /dev/null

[th3w4y]

@walkerlee just to check if file was modified.. cool
it still downloads the full file i guess the server does not server the Last-Modified header...

for the https://api.github.com/repos/$BUILD_REPO/commits/$BUILD_BRANCH github.com serves the Last-Modified flag very nice and we should not re-download the 3M archive every build...

looks like docker does not actually look at Last-Modified header, i must have seen some FR that is not implemented

[walkerlee]

@th3w4y let's me create a new PR

[th3w4y]

~~@walkerlee ~~
~~actually... ~~
Is this invalidating the cache if there is a new image??? or is it invalidating every time cause it does not server the Last-Modified?

ADD http://pgoapi.com/pgoencrypt.tar.gz /dev/null

looks like docker does not actually look at Last-Modified header, i must have seen some FR that is not implemented

[th3w4y]

my bad... github.com also does not give the Last-Modified 👎