Fix incubate eggs #4973
Merged
Fix incubate eggs #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Need of api call to update inventory when an egg hatchs to be able to encounter the pokemon that hatched * Reverted/removed 'except IndexError', not needed now
|
@DeXtroTip, thanks for your PR! By analyzing the annotation information on this pull request, we identified @solderzzc, @reddivision and @douglascamata to be potential reviewers |
|
👍 |
|
Let's have it merged. |
|
out of curiosity, does the spin fort task add eggs to inventory ? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Since
incubate_eggstask is not making an api call anymore and is using cached inventory, when an egg hatches it couldn't find it since it wouldn't appear on the inventory.It now updates inventory after an egg hatches so it can get data about the Pokemon.
Fixes/Resolves/Closes (please use correct syntax):