Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade improvements #4982

Merged
merged 1 commit into from
Aug 31, 2016
Merged

Upgrade improvements #4982

merged 1 commit into from
Aug 31, 2016

Conversation

julienlavergne
Copy link
Contributor

  • Add upgrade_level parameter
  • Fix a mistake in upgrade cost
  • Some refactoring

solderzzc
solderzzc reviewed Aug 31, 2016
View reviewed changes
pokemongo_bot/cell_workers/pokemon_optimizer.py
@@ -154,14 +155,15 @@ def work(self):
xp_all += xp

self.apply_optimization(transfer_all, evolve_all, upgrade_all, xp_all)
inventory.update_web_inventory()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this deleted by merge issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it is just not needed. Web inventory is saved at next loop.

@julienlavergne
Add upgrade_level parameter
755be7e 
Fix a mistake in upgrade cost
Some refactoring
Top default to 0 = all
@solderzzc
Copy link
Contributor

solderzzc commented Aug 31, 2016 •
edited by alexyaoyang
Loading

👍

Approved with PullApprove

@solderzzc solderzzc merged commit 50320ec into PokemonGoF:dev Aug 31, 2016
@z-jun
Copy link

z-jun commented Sep 1, 2016

Hi, very useful should be extension of evolve_for_xp parametr with an white/black list of pokemons/groups. Idea is to save candies for upgrades while evolving for xp on trash mons. For example:

evolve_for_xp: [ "all", "!Eevee", "!Gym"],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienlavergne @solderzzc @z-jun