Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyline handle Google Directions API request exception without raise #5026

Merged
merged 1 commit into from
Sep 1, 2016
Merged

Polyline handle Google Directions API request exception without raise #5026

merged 1 commit into from
Sep 1, 2016

Conversation

th3w4y
Copy link
Contributor

@th3w4y th3w4y commented Sep 1, 2016

Short Description:

handle IndexError in request response from the Google Directions API

Two cases are noticed:
a)
In case of API limit reached we get back we get a status 200 code with an empty routes []

{u'error_message': u'You have exceeded your rate-limit for this API.',
u'routes': [],
u'status': u'OVER_QUERY_LIMIT'
}

b) ZERO_RESULTS {
"geocoded_waypoints" : [ {}, {} ],
"routes" : [],
"status" : "ZERO_RESULTS"
}

Fixes/Resolves/Closes (please use correct syntax):

@mention-bot
Copy link

@th3w4y, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kanemasa1987, @solderzzc and @alexyaoyang to be potential reviewers

@th3w4y th3w4y changed the title handle request exception with our raise Polyline handle Google Directions API request exception without raise Sep 1, 2016
@solderzzc
Copy link
Contributor

solderzzc commented Sep 1, 2016

👍

Approved with PullApprove

@solderzzc solderzzc merged commit 897a274 into PokemonGoF:dev Sep 1, 2016
@th3w4y th3w4y deleted the issue#5020 branch September 1, 2016 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants